Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeed (ticdc): fix data lost when pause and resume changefeed while executing DDL. #7683

Merged
merged 2 commits into from
Nov 22, 2022
Merged

changefeed (ticdc): fix data lost when pause and resume changefeed while executing DDL. #7683

merged 2 commits into from
Nov 22, 2022

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Nov 22, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #7682

What is changed and how it works?

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Fix an issue that causes data lost when pause and resume changefeed while executing DDL.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 22, 2022
@asddongmen asddongmen requested review from zhaoxinyu and removed request for hicqu November 22, 2022 09:41
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 22, 2022
@asddongmen
Copy link
Contributor Author

/run-integration-tests

@asddongmen asddongmen changed the title changefeed (ticdc): fix data lost when pause and resume changefeed while executing drop table DDL. changefeed (ticdc): fix data lost when pause and resume changefeed while executing DDL. Nov 22, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2022
@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f90fdc4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022 •
edited
Loading

Codecov Report

Merging #7683 (4297b87) into master (bf9e9ad) will decrease coverage by 0.0469%.
The diff coverage is 23.0769%.

Additional details and impacted files
Flag Coverage Δ
cdc 66.2746% <18.9873%> (-0.0728%) ⬇️
dm 52.1129% <ø> (-0.0498%) ⬇️
engine 64.0202% <81.8181%> (-0.0023%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7683        +/-   ##
================================================
- Coverage   59.9132%   59.8663%   -0.0470%     
================================================
  Files           810        810                
  Lines         93098      93191        +93     
================================================
+ Hits          55778      55790        +12     
- Misses        32472      32535        +63     
- Partials       4848       4866        +18

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed do-not-merge/needs-triage-completed labels Nov 22, 2022
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Nov 22, 2022
@asddongmen
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 719d270 into pingcap:master Nov 22, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7684.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 22, 2022
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#7683
5b0cbfe 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7685.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 22, 2022
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#7683
49326fd 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7686.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 22, 2022
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#7683
3dba620 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2022
Closed
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 22, 2022
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#7683
ec37c8f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7687.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7688.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 22, 2022
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#7683
640a41c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Nov 25, 2022
@ti-chi-bot
changefeed (ticdc): fix data lost when pause and resume changefeed wh…
1a51b9b 
…ile executing DDL. (#7683) (#7686)

close #7682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@overvenus overvenus overvenus approved these changes

@zhaoxinyu zhaoxinyu Awaiting requested review from zhaoxinyu

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data lost when pause and resume changefeed while executing drop table DDL.
6 participants
@asddongmen @ti-chi-bot @codecov-commenter @overvenus @3AceShowHand @nongfushanquan